Added the docs for the "groups" constraint option #11092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
suggested changes
Mar 6, 2019
| @@ -10,6 +10,7 @@ an object and all sub-objects associated with it. | |||
| +----------------+---------------------------------------------------------------------+ | |||
| | Options | - `traverse`_ | | |||
| | | - `payload`_ | | |||
| | | - `groups`_ | | |||
There was a problem hiding this comment.
This is tricky ... because the original options are not sorted either ... I'm going to try to fix some of the issues you reported ... but I won't make many changes. I want to submit a PR to 4.2 to change the format of the RST tables (they are a nightmare to maintain right now) and to sort all options (lots of them are not). I cannot do this in 3.4 because it will be impossible to merge in 4.2. Too many conflicts. Thanks for understanding.
HeahDude
approved these changes
Mar 7, 2019
javiereguiluz
added a commit
that referenced
this pull request
Mar 7, 2019
…reguiluz) This PR was squashed before being merged into the 3.4 branch (closes #11092). Discussion ---------- Added the docs for the "groups" constraint option This continues #9557. Question to reviewers: does this option apply to Valid and All constraints too? Commits ------- da9aa0e Added the docs for the \"groups\" constraint option
javiereguiluz
added a commit
that referenced
this pull request
Mar 7, 2019
This PR was squashed before being merged into the 4.2 branch (closes #11101). Discussion ---------- Sort all validator constraints options This continues #11092 and: simplifies RST tables, sorts option names and option descriptions (and fix some minor issues like missing option names in the tables). It's impossible to review (because git doesn't detect correctly all the moved contents), so I'm going to merge it. Commits ------- 34d8337 Sort all validator constraints options
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #9557.
Question to reviewers: does this option apply to Valid and All constraints too?